add rustdoc feature support #3470
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
TroyKomodo
force-pushed
the
troy/rustdoc-features
branch
from
8a54a2c to
fb53017
Compare
There was a problem hiding this comment.
Thanks! This looks very reasonable - please can you add a test or two?
There are some unit tests in https://github.com/bazelbuild/rules_rust/tree/main/test/unit/rustdoc you can write a unit test for (which could show that the flags are passed to the command line)
Thanks!
TroyKomodo
force-pushed
the
troy/rustdoc-features
branch
from
a9d0d9d to
15108ca
Compare
TroyKomodo
force-pushed
the
troy/rustdoc-features
branch
from
15108ca to
b2a5ed2
Compare
|
@illicitonion the error here looks spurious |
|
Thanks for the test! I agree the failures look unrelated, unfortunately we have no way of bypassing or rerunning CI ourselves, but if you can push either empty commits or merge-main commits to this branch until things go green, that'd be super handy! (I'd do this myself, but I don't have permission to push to your fork) |
|
Oh there is a buildifier error though :) |
crate_featuresto be saved as part ofCrateInforust_docandrust_doc_testto include the features of the crate when building the docs (enabled by default)This is my first time using bazel so I am not 100% sure of my work, feedback greatly appreciated.
fixes #511